Ignore coverage data, add tests for PilgrimContext

This commit is contained in:
Miroslav Vasilev 2025-03-18 21:03:00 +02:00
parent 6d90298d24
commit 2c58d9750b
3 changed files with 49 additions and 66 deletions

1
.gitignore vendored
View file

@ -9,6 +9,7 @@
*.so *.so
*.dylib *.dylib
target/** target/**
coverage/**
# Test binary, built with `go test -c` # Test binary, built with `go test -c`
*.test *.test

View file

@ -89,75 +89,57 @@ func Test_PilgrimContext_EnvDriverOverridesEnvUrlDriver(t *testing.T) {
) )
} }
// func Test_PilgrimContext_EnvDriverOverridesEnvUrlDriver(t *testing.T) { func Test_PilgrimContext_CliUrlDriverOverridesEnvDriver(t *testing.T) {
// context, _, _ := createPilgrimContextWithDependencies( runTest(
// map[string]string{}, func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// map[string]string{ env.EXPECT().Driver().Return(pilgrim_conf.DbDriver_Postgres, true)
// EnvVarKey_Url: "mariadb://env_host:3306/env_segment1/env_segment2?env_arg1=env_val1&env_arg2=env_val2", cli.EXPECT().Url().Return("mssql://cli_host:1433", true)
// EnvVarKey_Driver: "postgres", },
// }, func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// ) ctx := pilgrim_conf.NewPilgrimContext(cli, env)
// assert.Equal(t, DbDriver_Postgres, context.UrlParts().Driver) assert.Equal(t, pilgrim_conf.DbDriver_MSSQL, ctx.UrlParts().Driver)
// } },
)
}
// func Test_PilgrimContext_CliUrlDriverOverridesEnvDriver(t *testing.T) { func Test_PilgrimContext_CliDriverOverridesEnvDriver(t *testing.T) {
// context, _, _ := createPilgrimContextWithDependencies( runTest(
// map[string]string{ func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// Flag_Url: CliUrlValue, env.EXPECT().Driver().Return(pilgrim_conf.DbDriver_MSSQL, true)
// }, cli.EXPECT().Driver().Return(pilgrim_conf.DbDriver_MariaDB, true)
// map[string]string{ },
// EnvVarKey_Driver: "mariadb", func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// }, ctx := pilgrim_conf.NewPilgrimContext(cli, env)
// )
// assert.Equal(t, CliDriverValue, context.UrlParts().Driver) assert.Equal(t, pilgrim_conf.DbDriver_MariaDB, ctx.UrlParts().Driver)
// } },
)
}
// func Test_PilgrimContext_CliDriverOverridesEnvDriver(t *testing.T) { func Test_PilgrimContext_EnvDriverIsUsedIfNoCliDriverProvided(t *testing.T) {
// context, _, _ := createPilgrimContextWithDependencies( runTest(
// map[string]string{ func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// Flag_Driver: string(CliDriverValue), env.EXPECT().Driver().Return(pilgrim_conf.DbDriver_MSSQL, true)
// }, },
// map[string]string{ func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// EnvVarKey_Driver: "mariadb", ctx := pilgrim_conf.NewPilgrimContext(cli, env)
// },
// )
// assert.Equal(t, CliDriverValue, context.UrlParts().Driver) assert.Equal(t, pilgrim_conf.DbDriver_MSSQL, ctx.UrlParts().Driver)
// } },
)
}
// func Test_PilgrimContext_EnvDriverIsUsedIfNoCliDriverProvided(t *testing.T) { func Test_PilgrimContext_EnvUrlDriverIsNotUsedIfCliDriverOverrideProvided(t *testing.T) {
// context, _, _ := createPilgrimContextWithDependencies( runTest(
// map[string]string{}, func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
// map[string]string{ env.EXPECT().Url().Return("mysql://localhost:3306", true)
// EnvVarKey_Driver: "mariadb", cli.EXPECT().Driver().Return(pilgrim_conf.DbDriver_MariaDB, true)
// }, },
// ) func(env *pilgrim_mock.EnvVarRetriever, cli *pilgrim_mock.CliFlagRetriever) {
ctx := pilgrim_conf.NewPilgrimContext(cli, env)
// assert.Equal(t, DbDriver_MariaDB, context.UrlParts().Driver) assert.Equal(t, pilgrim_conf.DbDriver_MariaDB, ctx.UrlParts().Driver)
// } },
)
// func Test_PilgrimContext_EnvUrlDriverIsUsedIfNoCliDriverProvided(t *testing.T) { }
// context, _, _ := createPilgrimContextWithDependencies(
// map[string]string{},
// map[string]string{
// EnvVarKey_Url: "mariadb://env_host:3306/env_segment1/env_segment2?env_arg1=env_val1&env_arg2=env_val2",
// },
// )
// assert.Equal(t, DbDriver_MariaDB, context.UrlParts().Driver)
// }
// func Test_PilgrimContext_EnvUrlDriverIsNotUsedIfNoCliDriverOverrideProvided(t *testing.T) {
// context, _, _ := createPilgrimContextWithDependencies(
// map[string]string{
// Flag_Driver: "postgres",
// },
// map[string]string{
// EnvVarKey_Url: "mariadb://env_host:3306/env_segment1/env_segment2?env_arg1=env_val1&env_arg2=env_val2",
// },
// )
// assert.Equal(t, DbDriver_Postgres, context.UrlParts().Driver)
// }

View file

@ -1,4 +1,4 @@
package pilgrim package main
import ( import (
"log" "log"